Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bios.rs: add adopt-and-update #723

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

HuijingHei
Copy link
Member

Fixes #717

Copy link

openshift-ci bot commented Sep 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@HuijingHei
Copy link
Member Author

Hold on, need to deduplicate the code first.

@HuijingHei HuijingHei force-pushed the adopt-bios branch 2 times, most recently from acf237d to 11daf96 Compare September 12, 2024 12:46
Copy link
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks sane to me, just a few nits.
Thanks for working on this!

src/bios.rs Outdated Show resolved Hide resolved
src/component.rs Outdated Show resolved Hide resolved
src/component.rs Outdated Show resolved Hide resolved
@HuijingHei HuijingHei force-pushed the adopt-bios branch 2 times, most recently from ddcd60a to 920dcf1 Compare September 13, 2024 02:15
@HuijingHei HuijingHei marked this pull request as ready for review September 18, 2024 02:02
@HuijingHei HuijingHei merged commit 4c5a514 into coreos:main Sep 18, 2024
12 checks passed
@HuijingHei HuijingHei deleted the adopt-bios branch September 18, 2024 02:58
HuijingHei added a commit to HuijingHei/bootupd that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adoption failure on Atomic Desktops using BIOS
2 participants